Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fee calculation #30

Merged
merged 7 commits into from
May 9, 2023
Merged

Fix fee calculation #30

merged 7 commits into from
May 9, 2023

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Apr 24, 2023

Fixes client-side fee calculation, similar to what was done here: moonbeam-foundation/moonbeam#2254. Notably, this queries the new api.call.transactionPayment.weightToFee and ...lengthToFee which use the underlying functions configured in the runtime for this pallet.

@notlesh notlesh requested a review from timbrinded May 8, 2023 19:12
timbrinded
timbrinded approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@timbrinded timbrinded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@notlesh notlesh merged commit 8352bde into main May 9, 2023
@crystalin crystalin deleted the notlesh-fix-fee-calculation branch May 23, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crystalin crystalin crystalin left review comments

@timbrinded timbrinded timbrinded approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notlesh @crystalin @timbrinded